MacOS compatibility#4
Open
perfaram wants to merge 1 commit intokangaderoo:masterfrom
perfaram:macOS-compat
Open
MacOS compatibility#4perfaram wants to merge 1 commit intokangaderoo:masterfrom perfaram:macOS-compat
perfaram wants to merge 1 commit intokangaderoo:masterfrom
perfaram:macOS-compat
Conversation
|
you should use hw.physicalcpu instead of hw.logicalcpu. the former gives the count of cores, the latter the number of virtual cores (physical + hyperthreading). so if you have a system with 2 physical cores and hyperthreading, you'll currently use 4 cores, which increases cpu usage, but doesn't improve performance over 2 cores because of all the context switching. |
Author
|
Will fix, thanks for the good advice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far I only found one issue : the count_processor function didn't work (no
procfson MacOS).This was fixed in 5dcbec0.
Found another issue ? Tell me :)