Skip to content

MacOS compatibility#4

Open
perfaram wants to merge 1 commit intokangaderoo:masterfrom
perfaram:macOS-compat
Open

MacOS compatibility#4
perfaram wants to merge 1 commit intokangaderoo:masterfrom
perfaram:macOS-compat

Conversation

@perfaram
Copy link
Copy Markdown

So far I only found one issue : the count_processor function didn't work (no procfs on MacOS).
This was fixed in 5dcbec0.
Found another issue ? Tell me :)

@grr
Copy link
Copy Markdown

grr commented May 28, 2018

you should use hw.physicalcpu instead of hw.logicalcpu. the former gives the count of cores, the latter the number of virtual cores (physical + hyperthreading). so if you have a system with 2 physical cores and hyperthreading, you'll currently use 4 cores, which increases cpu usage, but doesn't improve performance over 2 cores because of all the context switching.

@perfaram
Copy link
Copy Markdown
Author

perfaram commented Jun 1, 2018

Will fix, thanks for the good advice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants